Ability to directly emit device events on Android/Java side#36279
Closed
rshest wants to merge 1 commit into
Closed
Ability to directly emit device events on Android/Java side#36279rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43534174 |
|
Base commit: febf6b7 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43534174 |
rshest
force-pushed
the
export-D43534174
branch
from
ada5d25 to
2011d91
Compare
…#36279) Summary: Pull Request resolved: facebook#36279 [Changelog][Internal] To have a symmetry with the [corresponding C++ API for TurboModules](https://www.internalfb.com/code/fbsource/[929870c905c8fe68cb330ce96bda7eb703bb6ae6]/xplat/js/react-native-github/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h?lines=90), this adds a helper method `ReactContext.emitDeviceEvent`, which allows to send device events to JS (`RCTDeviceEventEmitter.emit`). This also allows for less boilerplate code and better discoverability. See the next diff in stack for the application. ## Changelog [Android][Added] ReactContext now has a method emitDeviceEvent, which can be used to send device events to RCTDeviceEventEmitter on the JavaScript side Reviewed By: NickGerleman Differential Revision: D43534174 fbshipit-source-id: 6b0c5b922f91f1e34e85e38f9b4263e15434b5b7
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43534174 |
rshest
force-pushed
the
export-D43534174
branch
from
2011d91 to
d92d17b
Compare
Contributor
|
This pull request has been merged in a8f0a4d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog][Internal]
To have a symmetry with the corresponding C++ API for TurboModules, this adds a helper method
ReactContext.emitDeviceEvent, which allows to send device events to JS (RCTDeviceEventEmitter.emit).This also allows for less boilerplate code and better discoverability.
See the next diff in stack for the application.
Reviewed By: NickGerleman
Differential Revision: D43534174