Skip to content

Use emitDeviceEvent in core ReactAndroid code#36280

Closed
rshest wants to merge 2 commits into
facebook:mainfrom
rshest:export-D43494167
Closed

Use emitDeviceEvent in core ReactAndroid code#36280
rshest wants to merge 2 commits into
facebook:mainfrom
rshest:export-D43494167

Conversation

@rshest
Copy link
Copy Markdown
Contributor

@rshest rshest commented Feb 24, 2023

Summary:
[Changelog][Internal]

As a follow-up to adding ReactContext.emitDeviceEvent (D43534174) this makes it used in the OSS part of RN.

Reviewed By: NickGerleman

Differential Revision: D43494167

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 24, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43494167

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2023

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 2a53ca5

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Feb 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,470,999 -414
android hermes armeabi-v7a 7,793,075 -446
android hermes x86 8,946,424 -420
android hermes x86_64 8,803,709 -420
android jsc arm64-v8a 9,105,144 -124
android jsc armeabi-v7a 8,302,076 -135
android jsc x86 9,155,469 -131
android jsc x86_64 9,414,522 -136

Base commit: febf6b7
Branch: main

rshest and others added 2 commits February 25, 2023 08:36
Differential Revision: D43534174

fbshipit-source-id: 13c05dc865b0eef57d209d7fc91c8aaa06e5a96a
Summary:
Pull Request resolved: facebook#36280

[Changelog][Internal]

As a follow-up to adding `ReactContext.emitDeviceEvent` (D43534174) this makes it used in the OSS part of RN.

Reviewed By: NickGerleman

Differential Revision: D43494167

fbshipit-source-id: 140ed1e8d9e6cf15b9b73ed0a32a7300dd73a5fb
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43494167

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 27, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in b108cbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants