RNGP - Add apiVersion/languageVersion to 1.5#36311
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43621083 |
Summary: Pull Request resolved: facebook#36311 Currently, we get the apiVersion/languageVersion for Kotlin that Gradle carries over. So what happens is that on older version of Gradle, we try to compile RNGP with older versions of Kotlin. There we have some functions missing (like `.uppercase()`) and the user will fail to build because of this. Here I'm setting `apiVersion` and `languageVersion` to Kotlin 1.5. Even if we compile with Kotlin 1.7, the compiler will make sure our code is compatible to be executed in a Kotlin 1.5 environment. Fixes facebook#36246 Changelog: [Internal] [Changed] - RNGP - Add apiVersion/languageVersion to 1.5 Reviewed By: cipolleschi Differential Revision: D43621083 fbshipit-source-id: af601e7022a91d484905dee224f02d8f180d38bb
cortinico
force-pushed
the
export-D43621083
branch
from
a3f5e0c to
09143d6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43621083 |
Base commit: 59157b8 |
|
This pull request was successfully merged by @cortinico in b360109. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in b360109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, we get the apiVersion/languageVersion for Kotlin that Gradle carries over.
So what happens is that on older version of Gradle, we try to compile RNGP with older versions of Kotlin.
There we have some functions missing (like
.uppercase()) and the user will fail to build because of this.Here I'm setting
apiVersionandlanguageVersionto Kotlin 1.5. Even if we compile with Kotlin 1.7,the compiler will make sure our code is compatible to be executed in a Kotlin 1.5 environment.
Fixes #36246
Changelog:
[Internal] [Changed] - RNGP - Add apiVersion/languageVersion to 1.5
Differential Revision: D43621083