Skip to content

Expose UnstableReactLegacyComponentDescriptor inside react/renderer/components/legacyviewmanagerinterop#36344

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D43500868
Closed

Expose UnstableReactLegacyComponentDescriptor inside react/renderer/components/legacyviewmanagerinterop#36344
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D43500868

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This adds the UnstableReactLegacyComponentDescriptor, part of the Fabric Interop Layer,
inside the react/renderer/components/legacyviewmanagerinterop module so that it can be included by the user externally.

If we wish to place it somewhere else, I'm more than happy to move it around.

Changelog:
[Internal] [Changed] - Expose UnstableReactLegacyComponentDescriptor inside react/renderer/components/legacyviewmanagerinterop

Reviewed By: mdvacca, cipolleschi

Differential Revision: D43500868

…omponents/legacyviewmanagerinterop

Summary:
This adds the `UnstableReactLegacyComponentDescriptor`, part of the Fabric Interop Layer,
inside the `react/renderer/components/legacyviewmanagerinterop` module so that it can be included by the user externally.

If we wish to place it somewhere else, I'm more than happy to move it around.

Changelog:
[Internal] [Changed] - Expose UnstableReactLegacyComponentDescriptor inside react/renderer/components/legacyviewmanagerinterop

Reviewed By: mdvacca, cipolleschi

Differential Revision: D43500868

fbshipit-source-id: b69d0c44aaa08f83b93d89233f5e7e128c7f306b
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 1, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43500868

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,499,793 +22,698
android hermes armeabi-v7a 7,814,290 +15,211
android hermes x86 8,977,637 +24,548
android hermes x86_64 8,834,434 +23,847
android jsc arm64-v8a 9,130,628 +22,452
android jsc armeabi-v7a 8,319,824 +14,980
android jsc x86 9,183,358 +24,326
android jsc x86_64 9,441,925 +23,606

Base commit: a49446b
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 2, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 071f6d2.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been reverted by 851c8c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants