Add Legacy Component to RNTester with Interop Layer#36360
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
… in the interop layer (facebook#36335) Summary: Pull Request resolved: facebook#36335 This change depends on [this PR](react-native-community/cli#1849) of the CLI that introduces the `unstable_reactLegacyComponent` field in the `react-native.config.js` file. This change introduce a JS script that reads that fields and generated a method in an object to return a list of components to be registered. The `RCTAppDelegate` has been updated to read those components and to automatically register them into the interop layer. Notice that a user can just update the `react-native.config.js` and rebuild the app to integrate these changes, there is no need to reinstall the pods. The idea behind this logic is to let the user know which components they are using with the interop layer, rather than rely on some black magic that could leave them blind to the need of actually migrate their apps. ## Changelog: [iOS][Changed] - Implement mechanism to register legacy components in the iOS Fabric interop layer Differential Revision: https://internalfb.com/D43665973 fbshipit-source-id: 22ef2ec769afad76624797e07c8e5bed28011449
Summary: This change is the iOS equivalent of D43731219 (facebook@ab55e12), but only for what concerns the RNTester example as the interop layer was already present in the codebase and exposed to the OSS. ## Changelog [internal] - Add example on how to consume a Legacy component in Fabric with the interop layer Reviewed By: cortinico Differential Revision: D43735699 fbshipit-source-id: e6d91ea4b3f3882629341ed6986c2e76148e47eb
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43735699 |
Base commit: ec99ba1 |
Contributor
|
This pull request has been merged in 4d7753e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change is the iOS equivalent of D43731219 (ab55e12), but only for what concerns the RNTester example as the interop layer was already present in the codebase and exposed to the OSS.
Changelog
[internal] - Add example on how to consume a Legacy component in Fabric with the interop layer
Reviewed By: cortinico
Differential Revision: D43735699