Skip to content

Add tests with more recent Rubies#36376

Closed
cipolleschi wants to merge 2 commits into
mainfrom
cipolleschi/add_tests_with_recent_rubies
Closed

Add tests with more recent Rubies#36376
cipolleschi wants to merge 2 commits into
mainfrom
cipolleschi/add_tests_with_recent_rubies

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

Summary

This change add more tests for iOS, using different versions of Ruby

Changelog

[iOS][Added] - Added smoke tests for iOS with Ruby 2.7.7 and 3.2.0

Test Plan

CircleCI must be green.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 5, 2023
@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Mar 5, 2023
@cipolleschi cipolleschi marked this pull request as ready for review March 5, 2023 14:18
@cipolleschi cipolleschi marked this pull request as draft March 5, 2023 14:19
@cipolleschi cipolleschi force-pushed the cipolleschi/add_tests_with_recent_rubies branch from 3215d0b to 516e6d4 Compare March 5, 2023 14:22
@cipolleschi cipolleschi changed the base branch from main to cipolleschi/use_system_ruby_in_CI March 5, 2023 14:43
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,508,872 +0
android hermes armeabi-v7a 7,822,848 +0
android hermes x86 8,986,447 +0
android hermes x86_64 8,842,620 +0
android jsc arm64-v8a 9,135,684 +0
android jsc armeabi-v7a 8,325,234 +0
android jsc x86 9,188,637 +0
android jsc x86_64 9,447,629 +0

Base commit: 947751f
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/add_tests_with_recent_rubies branch from 516e6d4 to 6a7df3a Compare March 5, 2023 15:03
@cipolleschi cipolleschi marked this pull request as ready for review March 5, 2023 18:50
@cipolleschi cipolleschi changed the base branch from cipolleschi/use_system_ruby_in_CI to main March 5, 2023 18:50
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi closed this Mar 5, 2023
@cipolleschi cipolleschi deleted the cipolleschi/add_tests_with_recent_rubies branch March 5, 2023 18:55
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43825344

cipolleschi pushed a commit that referenced this pull request Mar 5, 2023
Summary:
This change add more tests for iOS, using different versions of Ruby

## Changelog
[iOS][Added] - Added smoke tests for iOS with Ruby 2.7.7 and 3.2.0

Pull Request resolved: #36376

Test Plan: CircleCI must be green.

Differential Revision: D43825344

Pulled By: cipolleschi

fbshipit-source-id: 2d40f448263a5485cdc8a49c7b87e75b02f90de7
facebook-github-bot pushed a commit that referenced this pull request Mar 6, 2023
Summary:
This change add more tests for iOS, using different versions of Ruby

## Changelog
[iOS][Added] - Added smoke tests for iOS with Ruby 2.7.7 and 3.2.0

Pull Request resolved: #36376

Test Plan: CircleCI must be green.

Reviewed By: blakef

Differential Revision: D43825344

Pulled By: cipolleschi

fbshipit-source-id: 8d3f5a2d9688f4d58f0ad5573d7b21e059cab523
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Riccardo Cipolleschi in aac7150.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants