Skip to content

Change PerformanceApiExample to use ModulePathing#36478

Closed
TatianaKapos wants to merge 1 commit into
facebook:mainfrom
TatianaKapos:tk-fixwindowspathing
Closed

Change PerformanceApiExample to use ModulePathing#36478
TatianaKapos wants to merge 1 commit into
facebook:mainfrom
TatianaKapos:tk-fixwindowspathing

Conversation

@TatianaKapos
Copy link
Copy Markdown
Contributor

@TatianaKapos TatianaKapos commented Mar 14, 2023

Summary

Recent integration from Windows brought in PerformanceApiExample that uses relative pathing to access react-native library. This causes us to have to override the file since our file structure is different. microsoft/react-native-windows#11373

This PR changes the example to use module pathing instead.

Changelog

[GENERAL] [CHANGED] - Change PerformanceApiExample to use ModulePathing

Test Plan

Tested and passed Windows tests

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Mar 14, 2023
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,516,930 +0
android hermes armeabi-v7a 7,832,996 +0
android hermes x86 8,997,196 +0
android hermes x86_64 8,852,303 +0
android jsc arm64-v8a 9,141,112 +0
android jsc armeabi-v7a 8,332,996 +0
android jsc x86 9,195,811 +0
android jsc x86_64 9,453,760 +0

Base commit: 58d88ec
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 15, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache merged this pull request in 6a395cb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants