Use @rnx-kit/rn-changelog-generator for changelog validation in danger#36507
Closed
lunaleaps wants to merge 1 commit into
Closed
Use @rnx-kit/rn-changelog-generator for changelog validation in danger#36507lunaleaps wants to merge 1 commit into
lunaleaps wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 406f9fc |
Contributor
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Mar 20, 2023
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44183479 |
lunaleaps
force-pushed
the
use-changelog-validation-for-danger
branch
from
7b8c1d8 to
a5cb8ea
Compare
facebook#36507) Summary: Currently we have a tool (rnx-kit/rn-changelog-generator) that extracts changelog messages from our commit history to generate the changelog for a React Native release. In hopes of standardizing to one place where changelog validation occurs -- I've moved this logic to the package rnx-kit/rn-changelog-generator such that if the formatting ever changes, the changelog parsing is also updated. Changelog: [Internal] - Updating danger to use logic in rnx-kit/rn-changelog-generator for changelog validation. Pull Request resolved: facebook#36507 Test Plan: Tried `require`-ing the package and on a changelog message. I'm not sure exactly how to test a dangerfile -- IIRC it has to run off `main` Reviewed By: cortinico, cipolleschi Differential Revision: D44183479 Pulled By: lunaleaps fbshipit-source-id: 101dcf4188d628e500648dda5813562dff879c3d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44183479 |
lunaleaps
force-pushed
the
use-changelog-validation-for-danger
branch
from
a5cb8ea to
b1e4690
Compare
Contributor
|
@lunaleaps merged this pull request in d9f7c4c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we have a tool (@rnx-kit/rn-changelog-generator) that extracts changelog messages from our commit history to generate the changelog for a React Native release.
In hopes of standardizing to one place where changelog validation occurs -- I've moved this logic to the package @rnx-kit/rn-changelog-generator such that if the formatting ever changes, the changelog parsing is also updated.
Changelog: [Internal] - Updating danger to use logic in @rnx-kit/rn-changelog-generator for changelog validation.
Test Plan
Tried
require-ing the package and on a changelog message. I'm not sure exactly how to test a dangerfile -- IIRC it has to run offmain