Skip to content

Make FabricUIManager's Binding an interface#36613

Closed
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D44340265
Closed

Make FabricUIManager's Binding an interface#36613
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D44340265

Conversation

@javache
Copy link
Copy Markdown
Member

@javache javache commented Mar 23, 2023

Summary: Changelog: [Internal]

Differential Revision: D44340265

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 23, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 23, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 23, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,487 +75
android hermes armeabi-v7a 7,835,705 -2
android hermes x86 8,998,641 +90
android hermes x86_64 8,854,815 +100
android jsc arm64-v8a 9,140,857 +293
android jsc armeabi-v7a 8,333,003 +226
android jsc x86 9,194,547 +313
android jsc x86_64 9,453,640 +330

Base commit: 04df252
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@javache @facebook-github-bot
Make FabricUIManager's Binding an interface (facebook#36613)
05bb1a8 
Summary:
Pull Request resolved: facebook#36613

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D44340265

fbshipit-source-id: 698d871b1bb572173ddeb9aed0a76066ba1a6299
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44340265

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 27, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request has been merged in 406f9fc.

@javache javache deleted the export-D44340265 branch March 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javache @facebook-github-bot @analysis-bot