Skip to content

Attach Bridgeless nativeModuleProxy in TurboModuleManager#36626

Closed
RSNara wants to merge 1 commit into
facebook:mainfrom
RSNara:export-D43993197
Closed

Attach Bridgeless nativeModuleProxy in TurboModuleManager#36626
RSNara wants to merge 1 commit into
facebook:mainfrom
RSNara:export-D43993197

Conversation

@RSNara
Copy link
Copy Markdown
Contributor

@RSNara RSNara commented Mar 24, 2023

Summary:
In Bridgeless mode, With the TurboModule interop layer, the TurboModule system will need to customize the nativeModuleProxy global.

This customization would be much easier if the nativeModuleProxy global were installed by the TurboModule system (and not the Bridgeless core).

So, this diff moves nativeModuleProxy installation into the TurboModule system.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D43993197

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 24, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 24, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,521,948 +2,376
android hermes armeabi-v7a 7,837,934 +2,156
android hermes x86 9,001,251 +2,523
android hermes x86_64 8,857,210 +2,311
android jsc arm64-v8a 9,143,240 +2,379
android jsc armeabi-v7a 8,335,157 +2,157
android jsc x86 9,197,080 +2,533
android jsc x86_64 9,455,947 +2,307

Base commit: 4e0dfed
Branch: main

@RSNara RSNara force-pushed the export-D43993197 branch from 57a307b to 75008c4 Compare March 24, 2023 14:31
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 75008c4 to cb5337d Compare March 24, 2023 14:37
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 26, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from cb5337d to 658ca88 Compare March 26, 2023 18:09
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 26, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 658ca88 to 4ef701f Compare March 26, 2023 19:56
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 26, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 4ef701f to ce206ef Compare March 26, 2023 19:59
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 26, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from ce206ef to 6eb1888 Compare March 26, 2023 20:11
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 6eb1888 to 40726d3 Compare March 27, 2023 20:33
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 40726d3 to 840d65a Compare March 27, 2023 21:59
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 840d65a to 28a4416 Compare March 28, 2023 14:05
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 28a4416 to 39f9e2d Compare March 28, 2023 14:11
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 39f9e2d to 4823106 Compare March 28, 2023 14:17
@RSNara @facebook-github-bot
Attach Bridgeless nativeModuleProxy in TurboModuleBinding (facebook#3…
71f92ed 
…6626)

Summary:
Pull Request resolved: facebook#36626

In Bridgeless mode, With the TurboModule interop layer, the TurboModule system will need to customize the nativeModuleProxy global.

This customization would be much easier if the nativeModuleProxy global were installed by the TurboModule system (and not the Bridgeless core).

So, this diff moves nativeModuleProxy installation into the TurboModule system.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D43993197

fbshipit-source-id: 035a66d272a773ff9382e7fc3dc543154b04d3c4
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D43993197

@RSNara RSNara force-pushed the export-D43993197 branch from 4823106 to 71f92ed Compare March 28, 2023 15:24
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 28, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request has been merged in 7023962.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSNara @facebook-github-bot @analysis-bot