Make TurboModule system support int/float args/returns#36628
Closed
RSNara wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
Base commit: 4e0dfed |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
eedc910 to
e1aa57f
Compare
RSNara
force-pushed
the
export-D44000389
branch
from
e1aa57f to
a8323d5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
Contributor
Pranav-yadav
left a comment
Pranav-yadav
left a comment
There was a problem hiding this comment.
added comments for few nits :)
Comment on lines
252
to
253
Contributor
There was a problem hiding this comment.
Wouldn't it be nice if we have deprecation statement here as well ?
Just being curious since this is marked public
Contributor
There was a problem hiding this comment.
Suggested change
| * Interface to allow for creating and retrieving NativeModules. Why is this this class prefixed | |
| * Interface to allow for creating and retrieving NativeModules. Why is this class prefixed |
nit: extra this :)
Contributor
There was a problem hiding this comment.
Suggested change
| // jsRepresentation is also cached by by name by the TurboModuleManager | |
| // jsRepresentation is also cached by name by the TurboModuleManager |
nit: extra 'by' :)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
a8323d5 to
410a790
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
410a790 to
e562d20
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
e562d20 to
4ffe0a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
4ffe0a7 to
a343c2a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
a343c2a to
4873aab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
4873aab to
d2e8bb1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
d2e8bb1 to
6a6c7c3
Compare
RSNara
force-pushed
the
export-D44000389
branch
from
6a6c7c3 to
cdf8a6d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
Summary: In Bridgeless mode, With the TurboModule interop layer, the TurboModule system will need to customize the nativeModuleProxy global. This customization would be much easier if the nativeModuleProxy global were installed by the TurboModule system (and not the Bridgeless core). So, this diff moves nativeModuleProxy installation into the TurboModule system. Changelog: [Internal] Differential Revision: https://internalfb.com/D43993197 fbshipit-source-id: 898851eff800f5151bb09c6e40a8e2f5cdeb7ba1
Summary: ## Context Previously, jsRepresentation would only cache the **HostFunctions** returned from TurboModule::createHostFunction(). ## Changes This diff replaces TurboModule::createHostFunction() with TurboModule::create(). Now, jsRepresentation will cache **all** the **properties** returned from TurboModule::create(). ## Motivation For interop modules, constants will be exported as properties on the TurboModule HostObject. This diff allows those constants (which are non HostFunctions) to be cached. Changelog: [Internal] Differential Revision: https://internalfb.com/D44253229 fbshipit-source-id: b32ff9c108db414563dd4c81221af161029db965
Summary: Pull Request resolved: facebook#36628 The legacy NativeModule system supports integer and float in NativeModule method arguments and returns. This diff extends the TurboModule system for the same functionality. T his is necessary because the TurboModule system will now need to dispatch method calls to legacy NativeModules. NOTE: We can't actually test these changes until we run interop modules. Changelog: [Internal] Reviewed By: javache Differential Revision: D44000389 fbshipit-source-id: 5b2825164609549cc27f2ed04db0638d93712893
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44000389 |
RSNara
force-pushed
the
export-D44000389
branch
from
cdf8a6d to
449953a
Compare
Contributor
|
This pull request has been merged in cb07358. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The legacy NativeModule system supports integer and float in NativeModule method arguments and returns. This diff extends the TurboModule system for the same functionality. T
his is necessary because the TurboModule system will now need to dispatch method calls to legacy NativeModules.
NOTE: We can't actually test these changes until we run interop modules.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D44000389