Skip to content

Don't cache UIManager type inside the Event data structure#36677

Closed
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D44453812
Closed

Don't cache UIManager type inside the Event data structure#36677
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D44453812

Conversation

@rshest
Copy link
Copy Markdown
Contributor

@rshest rshest commented Mar 28, 2023 •
edited
Loading

Summary:

Changelog:

[Internal] - Don't cache UIManager type inside the Event data structure

A follow up to #36659

It's redundant, and it's good to have fewer "sources of truth" and keep the notion of UIManagerType separate from Event data structures.

Differential Revision: D44453812

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 28, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 5d97c95 to 4254661 Compare March 28, 2023 08:38
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 28, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,613 +41
android hermes armeabi-v7a 7,835,828 +50
android hermes x86 8,998,772 +44
android hermes x86_64 8,854,943 +44
android jsc arm64-v8a 9,140,837 -24
android jsc armeabi-v7a 8,332,981 -19
android jsc x86 9,194,531 -16
android jsc x86_64 9,453,619 -21

Base commit: 4e0dfed
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 4254661 to 822aa4b Compare March 28, 2023 10:21
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 822aa4b to 94238cf Compare March 28, 2023 12:02
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 94238cf to 815f0a0 Compare March 28, 2023 12:05
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 815f0a0 to 4cddde0 Compare March 28, 2023 12:10
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 4cddde0 to 53ca210 Compare March 28, 2023 12:36
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 53ca210 to d859752 Compare March 28, 2023 13:40
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from d859752 to 6258a10 Compare March 28, 2023 14:04
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from 6258a10 to dac7bfd Compare March 28, 2023 14:57
@rshest @facebook-github-bot
Don't cache UIManager type inside the Event data structure (facebook#…
3e21f21 
…36677)

Summary:
Pull Request resolved: facebook#36677

## Changelog:

[Internal] - Don't cache UIManager type inside the Event data structure

A follow up to facebook#36659

It's redundant, and it's good to have fewer "sources of truth" and keep the notion of UIManagerType separate from Event data structures.

Reviewed By: javache

Differential Revision: D44453812

fbshipit-source-id: 6bb1256fab9705b35e2b80678a3a6730501a54c9
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44453812

@rshest rshest force-pushed the export-D44453812 branch from dac7bfd to 3e21f21 Compare March 28, 2023 15:09
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 28, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2023

This pull request has been merged in 4a5f550.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rshest @facebook-github-bot @analysis-bot