Add github workflow for automatic API, topic, and component labeling of issues#36712
Add github workflow for automatic API, topic, and component labeling of issues#36712SlyCaptainFlint wants to merge 5 commits intofacebook:mainfrom
Conversation
Base commit: 9909711 |
|
Accepted to unblock you, but I think we should fix the |
kelset
left a comment
There was a problem hiding this comment.
LGTM
only nit: I wonder if there's a more future-proof way to list the components/apis/topics so that it's not a manually maintained list in the new file... is there a way we could fetch them from gh itself?
I like this idea a lot, though looking through the GH API, nothing jumps out at me as immediately helpful in this regard. Is there a source of truth, other than code (and the RN docs, which are not hosted on GH) for API, component, and topic lists today? |
sadly, I don't think so 😥 |
cortinico
left a comment
There was a problem hiding this comment.
LGTM 👍
Q for @SlyCaptainFlint: does this mirror the previous logic of react-native-bot? Asking as I believe we were checking also in the body somehow?
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
The only tag that was being applied based on information present in the issue body is |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint merged this pull request in d038e4e. |
Summary:
Adding a new github workflow script, which will run as part of the existing triage job that is triggered when an issue is labeled with the "Needs: Triage" label (this typically happens automatically when the issue is created).
This script will add an extensive list of possible labels corresponding to APIs, components, and topics (see the code for the full list).
The motivation for this change is to replace the last bit of meaningful functionality performed by react-native-bot, which will allow us to decommission that bot in favor of using github workflows for all issue and PR automation.
Changelog:
[INTERNAL] [CHANGED] - Updated API, topic, component labeling on issues to run from a GH workflow rather than an external bot action
Test Plan:
For examples of issues being labeled by this new script, see the open issues here: https://github.com/SlyCaptainFlint/react-native/issues
I did not test every possible label, but I tested at least one from each category (API, component, topic), and a combination of one or two of each.