Do not store scripts inside .github/workflows#36811
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Do not store scripts inside .github/workflows#36811cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44705878 |
cortinico
force-pushed
the
export-D44705878
branch
from
3d601df to
38625de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44705878 |
Base commit: d117453 |
Summary: Pull Request resolved: facebook#36811 Editing frequently the `.github/workflow` folder makes harder to use the `/rebase` command as it fails if there are edits to such folder in the middle of a rebase. I'm moving the .js files outside of that folder. Changelog: [Internal] [Changed] - Do not store scripts inside .github/workflows Reviewed By: sshic Differential Revision: D44705878 fbshipit-source-id: 47a2f60e9c9337dbe9f12c067aa02ee48ba9da38
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44705878 |
cortinico
force-pushed
the
export-D44705878
branch
from
38625de to
2881924
Compare
Contributor
|
This pull request has been merged in de2f01d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Editing frequently the
.github/workflowfolder makes harder to use the/rebasecommand as it fails if there are edits to such folder in the middleof a rebase.
I'm moving the .js files outside of that folder.
Changelog:
[Internal] [Changed] - Do not store scripts inside .github/workflows
Differential Revision: D44705878