Rename cleanAll to clean and refine it#36832
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: We used to use `cleanAll` instead of `clean` to do cleaning of everything due to a bug on AGP on how clean was performed. The bug is resolved, so we can now use `clean` properly. Moreover, we have sporadic failures when the codegen/lib/ folder is not cleaned up. This fixes it. Changelog: [Internal] [Changed] - Rename cleanAll to clean and refine it Reviewed By: cipolleschi Differential Revision: D44745849 fbshipit-source-id: 4c1031d50a19ea0e872870e9e9bfc235149b8963
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44745849 |
Base commit: 49f1237 |
Contributor
|
This pull request has been merged in 01100a2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We used to use
cleanAllinstead ofcleanto do cleaning of everything due to a bug on AGP on how clean was performed.The bug is resolved, so we can now use
cleanproperly.Moreover, we have sporadic failures when the codegen/lib/ folder is not cleaned up. This fixes it.
Changelog:
[Internal] [Changed] - Rename cleanAll to clean and refine it
Reviewed By: cipolleschi
Differential Revision: D44745849