Skip to content

W3CPointerEvents: use description to indicate HW requirements for tests#36840

Closed
adanoff wants to merge 1 commit into
facebook:mainfrom
adanoff:export-D44687709
Closed

W3CPointerEvents: use description to indicate HW requirements for tests#36840
adanoff wants to merge 1 commit into
facebook:mainfrom
adanoff:export-D44687709

Conversation

@adanoff
Copy link
Copy Markdown

@adanoff adanoff commented Apr 6, 2023

Summary:
Changelog: [Internal] - W3CPointerEvents: use description to indicate HW requirements for tests

As title. This lets users/testers know whether additional hardware is required to run each test and can give info on the test status (e.g. whether it's expected to fail). Tests with no description should be assumed to work without any special requirements.

Reviewed By: vincentriemer

Differential Revision: D44687709

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 6, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44687709

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,604,606 +363
android hermes armeabi-v7a 7,918,515 +365
android hermes x86 9,090,481 +379
android hermes x86_64 8,945,567 +371
android jsc arm64-v8a 9,173,824 +113
android jsc armeabi-v7a 8,365,490 +114
android jsc x86 9,231,483 +109
android jsc x86_64 9,490,182 +113

Base commit: 6bcf904
Branch: main

…ts (facebook#36840)

Summary:
Pull Request resolved: facebook#36840

Changelog: [Internal] - W3CPointerEvents: use description to indicate HW requirements for tests

As title. This lets users/testers know whether additional hardware is required to run each test and can give info on the test status (e.g. whether it's expected to fail). Tests with no description should be assumed to work without any special requirements.

Reviewed By: vincentriemer

Differential Revision: D44687709

fbshipit-source-id: 09c2308614566c8c64db6329701a42fd48b77ccf
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44687709

@adanoff adanoff force-pushed the export-D44687709 branch from 59d9563 to 7d97299 Compare April 6, 2023 18:51
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 6, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in a27270f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants