Skip to content

Fix occasional failures of triage-issue job#36846

Closed
SlyCaptainFlint wants to merge 2 commits intofacebook:mainfrom
SlyCaptainFlint:olga/label-workflow-empty-array-fix
Closed

Fix occasional failures of triage-issue job#36846
SlyCaptainFlint wants to merge 2 commits intofacebook:mainfrom
SlyCaptainFlint:olga/label-workflow-empty-array-fix

Conversation

@SlyCaptainFlint
Copy link
Copy Markdown
Contributor

Summary:

I added a new step to the triage-issue job last week, to add descriptive labels to issues based on their title. This job has occasionally be failing, like this. This happens when no applicable labels are found, and we send up an empty array to the add labels endpoint. Adding an array length check to protect against this case.

Changelog:

[INTERNAL] [FIXED] - Fixed occasional failures in the issue triage pipeline related to issue labeling

Test Plan:

Repro run in my repository before the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631843716 (note that the error is the same as in the example failure listed in the description)
And here is a success on the same issue after the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631920441

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 6, 2023
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,604,613 +0
android hermes armeabi-v7a 7,918,523 +0
android hermes x86 9,090,481 +0
android hermes x86_64 8,945,565 +0
android jsc arm64-v8a 9,173,833 +0
android jsc armeabi-v7a 8,365,493 +0
android jsc x86 9,231,488 +0
android jsc x86_64 9,490,181 +0

Base commit: bfaedfe
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 11, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in ad4a857.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants