rn_codegen: define a method to convert package.json codegenConfig into Buck format#36868
Closed
fkgozali wants to merge 1 commit into
Closed
rn_codegen: define a method to convert package.json codegenConfig into Buck format#36868fkgozali wants to merge 1 commit into
fkgozali wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
Base commit: ad4a857 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
d90b2a3 to
6eaa88b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
6eaa88b to
31bfbd8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
31bfbd8 to
0fdbd89
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
0fdbd89 to
de8545d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
de8545d to
0114d38
Compare
fkgozali
force-pushed
the
export-D44857743
branch
from
0114d38 to
3453599
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
…o Buck format (facebook#36868) Summary: Pull Request resolved: facebook#36868 Given a codegenConfig definition in a library's package.json, convert it into Buck specific codegen format, as defined by the kwargs of rn_codegen(). Reference: https://reactnative.dev/docs/next/new-architecture-library-intro#configure-codegen Changelog: [Internal] Reviewed By: cortinico, mdvacca Differential Revision: D44857743 fbshipit-source-id: 0f4a3069b6c9abc7a4931257716a53c3074aa5d3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44857743 |
fkgozali
force-pushed
the
export-D44857743
branch
from
3453599 to
0e37250
Compare
Contributor
|
This pull request has been merged in d49f1eb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Given a codegenConfig definition in a library's package.json, convert it into Buck specific codegen format, as defined by the kwargs of rn_codegen().
Reference:
https://reactnative.dev/docs/next/new-architecture-library-intro#configure-codegen
Changelog: [Internal]
Differential Revision: D44857743