Back out "Fix escaping in the URL conversion"#36939
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45061886 |
|
Summary: Pull Request resolved: facebook#36939 Revert changes implemented in [this commit](facebook@2b4e1f5). It makes some e2e internal test fail, although it is unclear why. ## Changelog: [General][Fixed] - Rollback changes on URL escaping Reviewed By: philIip, mdvacca Differential Revision: D45061886 fbshipit-source-id: c99b030e073c7494b3f7b52bf7193dd363e0fdb9
cipolleschi
force-pushed
the
export-D45061886
branch
from
a7c7413 to
8370b3f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45061886 |
Contributor
|
This pull request has been merged in 145af9a. |
Base commit: 4ad2fc8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Revert changes implemented in this commit.
It makes some e2e internal test fail, although it is unclear why.
Original commit changeset: 03628d86966c
Original Phabricator Diff: D44958172
Reviewed By: philIip, mdvacca
Differential Revision: D45061886