Skip to content

Delete stale file generatedComponentApiDocs.js#37053

Closed
Saadnajmi wants to merge 2 commits into
facebook:mainfrom
Saadnajmi:stale
Closed

Delete stale file generatedComponentApiDocs.js#37053
Saadnajmi wants to merge 2 commits into
facebook:mainfrom
Saadnajmi:stale

Conversation

@Saadnajmi
Copy link
Copy Markdown
Contributor

Summary:

I noticed this file was 4 years old in both React Native and React Native macOS, and figured it was safe to delete ¯_(ツ)_/¯

Changelog:

[INTERNAL] [REMOVED] - Remove stale generated doc file

Test Plan:

N/A

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Apr 23, 2023
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 23, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,622,804 -2,450
android hermes armeabi-v7a 7,936,158 -1,862
android hermes x86 9,109,453 -2,587
android hermes x86_64 8,964,474 -2,461
android jsc arm64-v8a 9,187,054 -2,259
android jsc armeabi-v7a 8,377,930 -1,603
android jsc x86 9,245,111 -2,333
android jsc x86_64 9,503,774 -2,200

Base commit: efc6e14
Branch: main

@jacdebug
Copy link
Copy Markdown
Contributor

Thanks for the cleanup. I see some references of this file can you verify and cleanup those as well?

const OUTPUT_PATH = path.join(RN_ROOT, 'docs', 'generatedComponentApiDocs.js');

https://github.com/facebook/react-native-website/blob/fe13c0bddd52a679606c99ce8f31a8ff0e76dd43/sync-api-docs/magic.js#L10

@Saadnajmi
Copy link
Copy Markdown
Contributor Author

Thanks for the cleanup. I see some references of this file can you verify and cleanup those as well?

const OUTPUT_PATH = path.join(RN_ROOT, 'docs', 'generatedComponentApiDocs.js');

https://github.com/facebook/react-native-website/blob/fe13c0bddd52a679606c99ce8f31a8ff0e76dd43/sync-api-docs/magic.js#L10

Updated the PR to remove the JS file, as well a second PR to update the website: facebook/react-native-website#3699

@Saadnajmi
Copy link
Copy Markdown
Contributor Author

Anything blocking this?

@jacdebug jacdebug requested a review from elicwhite May 5, 2023 11:10
@jacdebug
Copy link
Copy Markdown
Contributor

jacdebug commented May 5, 2023

Let's get a confirmation from @TheSavior finally!

@Saadnajmi
Copy link
Copy Markdown
Contributor Author

Pinging again, any blocker here?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@TheSavior has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 28, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@TheSavior merged this pull request in 594cf1f.

@Saadnajmi Saadnajmi deleted the stale branch August 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Type: Removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants