Back out "Reapply Fix escaping in the URL conversion"#37103
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: Re backout the fix as there are some edge cases not handled properly internally. ## Changelog: [iOS][Fixed] - Revert change in URL escaping Reviewed By: javache, sammy-SC, rshest Differential Revision: D45309232 fbshipit-source-id: 8d97a669da4668aab0bde61233ede895deb3e6c6
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45309232 |
Contributor
|
This pull request has been merged in 5ff19f0. |
Base commit: 495506d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Re backout the fix as there are some edge cases not handled properly internally.
Changelog:
[iOS][Fixed] - Revert change in URL escaping
Reviewed By: javache, sammy-SC, rshest
Differential Revision: D45309232