Avoid retaining TurboModuleManager in AppDelegate#37104

Closed

javache wants to merge 1 commit into

facebook:mainfrom

javache:export-D45310066

Member

javache commented Apr 26, 2023

Summary:
The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context.

Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager.

Differential Revision: D45310066

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from 85527d2 to 92801c2 Compare

April 26, 2023 12:57

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from 92801c2 to ef8299d Compare

April 26, 2023 13:04

javache force-pushed the export-D45310066 branch from ef8299d to 4e25612 Compare

April 26, 2023 13:10

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

analysis-bot commented Apr 26, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,623,502	+0
android	hermes	armeabi-v7a	7,936,340	+0
android	hermes	x86	9,110,446	+0
android	hermes	x86_64	8,965,250	+0
android	jsc	arm64-v8a	9,187,538	+0
android	jsc	armeabi-v7a	8,377,834	+0
android	jsc	x86	9,245,844	+0
android	jsc	x86_64	9,504,290	+0

Base commit: 0dcf81b
Branch: main

javache force-pushed the export-D45310066 branch from 4e25612 to d06bbb0 Compare

April 26, 2023 14:25

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

1 similar comment

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from d06bbb0 to a5860f2 Compare

April 26, 2023 14:53

javache force-pushed the export-D45310066 branch from a5860f2 to d83a5e4 Compare

April 26, 2023 15:00

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from d83a5e4 to c327312 Compare

April 26, 2023 15:40

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from c327312 to d794de3 Compare

April 26, 2023 15:50

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from d794de3 to a2dd5be Compare

April 27, 2023 09:11

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from a2dd5be to 818f01e Compare

April 27, 2023 09:18

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from 818f01e to 4dc795a Compare

April 27, 2023 09:37


          Avoid retaining TurboModuleManager in AppDelegate (facebook#37104)

Summary:
Pull Request resolved: facebook#37104

The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context.

Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D45310066

fbshipit-source-id: 5263280e14d959f0d7530571e2614a59c8838088

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45310066

javache force-pushed the export-D45310066 branch from 4dc795a to 7050567 Compare

April 27, 2023 10:03

facebook-github-bot closed this in

ec1ab73

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request has been merged in ec1ab73.

javache deleted the export-D45310066 branch

April 27, 2023 14:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner