Add example in RNTester to use events with arrays#37143
Closed
cipolleschi wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
c311060 to
6146975
Compare
cipolleschi
force-pushed
the
export-D45357873
branch
from
6146975 to
e96bbdf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
Base commit: 1cd0f57 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
e96bbdf to
636c702
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
636c702 to
51b26bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
51b26bd to
c055581
Compare
cipolleschi
force-pushed
the
export-D45357873
branch
from
c055581 to
8207b74
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
8207b74 to
2debbed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
2debbed to
271cbf9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
cipolleschi
force-pushed
the
export-D45357873
branch
from
271cbf9 to
187b5fd
Compare
Summary: This diff introduce support to parse arrays in events. We support parsing Arrays of: - Boolean - Double - Float - Int32 - String Enums - String - Objects - Arrays ## Changelog: [General][Added] - Add generic support for Arrays in Events parsing Differential Revision: https://internalfb.com/D45268779 fbshipit-source-id: 8dbbaf33b3ce2489e3e1b03741a5465012dd05a0
Summary: This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Differential Revision: https://internalfb.com/D45321685 fbshipit-source-id: c52faab4aa63efcc161b7623146286832a2e3619
Summary: Pull Request resolved: facebook#37143 This change add an example on how to use events with arrays in the New Architecture in RNTester. ## Changelog: [Internal] - Add Examples on RNTester on how to send events with arrays from Native to JS Reviewed By: cortinico Differential Revision: D45357873 fbshipit-source-id: 9f4a201f180e0e92adf7ac4154509d65642c642e
cipolleschi
force-pushed
the
export-D45357873
branch
from
187b5fd to
de4c7ba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45357873 |
Contributor
|
This pull request has been merged in 8c8f7a5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change add an example on how to use events with arrays in the New Architecture in RNTester.
Changelog:
[Internal] - Add Examples on RNTester on how to send events with arrays from Native to JS
Differential Revision: D45357873