Add React-FabricImage pod to solve Circulare dependency between Fabric image component and ImageManager#37276
Closed
cipolleschi wants to merge 1 commit into
Closed
Add React-FabricImage pod to solve Circulare dependency between Fabric image component and ImageManager#37276cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
Base commit: e540d05 |
cipolleschi
force-pushed
the
export-D45517278
branch
from
8a050be to
2b70add
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
force-pushed
the
export-D45517278
branch
from
2b70add to
f22797c
Compare
cipolleschi
force-pushed
the
export-D45517278
branch
from
f22797c to
b8052a9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Reviewed By: NickGerleman Differential Revision: D45517278 fbshipit-source-id: 5eda8630715351798671978e67019a71876ded37
cipolleschi
force-pushed
the
export-D45517278
branch
from
b8052a9 to
720998f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 89c991bed7c170c6bb2f7f6e8b19ec64847f5454
Contributor
|
This pull request has been merged in 44af6ca. |
|
@cipolleschi getting: I believe this is the culprit. Currently debugging why. |
|
Figured it out, we had: Changing it to the following seems to have fixed this issue: Leaving it here as it may help someone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager.
Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking.
Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec.
This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths.
Changelog
[iOS][Breaking] - Add React-FabricImage pod.
Differential Revision: D45517278