Skip to content

Enhance labeling workflow#37324

Closed
SlyCaptainFlint wants to merge 1 commit intofacebook:mainfrom
SlyCaptainFlint:olga/patch-upgrade-workflow
Closed

Enhance labeling workflow#37324
SlyCaptainFlint wants to merge 1 commit intofacebook:mainfrom
SlyCaptainFlint:olga/patch-upgrade-workflow

Conversation

@SlyCaptainFlint
Copy link
Copy Markdown
Contributor

Summary:

This PR does two things:

  1. Improves the labeling workflow in cases where the user is on a supported version but a higher patch number is available. Now, the label name will be friendlier ('Newer Patch Available') and we will report the version they should consider upgrading to in the message body. Once this change is merged, I can also rename all existing versions of this label for consistency.
  2. Moves the addDescriptiveLabels.js script to the workflow-scripts folder for consistency with the other workflow scripts.

Changelog:

[INTERNAL] [CHANGED] - Enhancing issue triage workflow for patch versioning

Test Plan:

See some examples of the workflow run in my fork: https://github.com/SlyCaptainFlint/react-native/issues

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 8, 2023
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,719,567 -11
android hermes armeabi-v7a 8,030,283 -9
android hermes x86 9,207,114 -13
android hermes x86_64 9,060,561 -12
android jsc arm64-v8a 9,283,922 -11
android jsc armeabi-v7a 8,472,083 -11
android jsc x86 9,342,868 -13
android jsc x86_64 9,599,919 -10

Base commit: 68ce28a
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 9, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@NickGerleman merged this pull request in b6f269e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants