Pressable: disable click bubbling in Pressable#37542
Closed
adanoff wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46081810 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46081810 |
Base commit: be8af22 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46081810 |
Summary: Pull Request resolved: facebook#37542 Changelog: [General] [Changed] - Pressable: prevent click bubbling in Pressable This diff modifies pressability such that `onClick` events for pressables will only result in `onPress` being called when the pressable in question is both the `target` and the `currentTarget` for the event. This is only really relevant for nested pressables, where `click` received by the inner pressable may bubble up to the parent pressable (this change effectively prevents that from happening). A future change will update the click event on Android to be bubbling (currently its a direct event); this change will reduce the possibility of breakages from that change. Reviewed By: vincentriemer Differential Revision: D46081810 fbshipit-source-id: 1be1126a03b56b87a603be499d486a90abbcbfa3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46081810 |
Contributor
|
This pull request has been merged in a449291. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General] [Changed] - Pressable: prevent click bubbling in Pressable
This diff modifies pressability such that
onClickevents for pressables will only result inonPressbeing called when the pressable in question is both thetargetand thecurrentTargetfor the event.This is only really relevant for nested pressables, where
clickreceived by the inner pressable may bubble up to the parent pressable (this change effectively prevents that from happening). A future change will update the click event on Android to be bubbling (currently its a direct event); this change will reduce the possibility of breakages from that change.Reviewed By: vincentriemer
Differential Revision: D46081810