Skip to content

decouple RCTHost bundleURL setter from delegate#37566

Closed
philIip wants to merge 1 commit into
facebook:mainfrom
philIip:export-D45937853
Closed

decouple RCTHost bundleURL setter from delegate#37566
philIip wants to merge 1 commit into
facebook:mainfrom
philIip:export-D45937853

Conversation

@philIip
Copy link
Copy Markdown
Contributor

@philIip philIip commented May 25, 2023

Summary:
Changelog: [Internal]

in this diff stack, i remove - (NSURL *)getBundleURL; from the bridgeless API.

the reason for this is because the bundle url does not change in the middle of an app session, unless for developer mode, so it's more robust for us to pass it as a dependency.

at the end of the diff stack, i'll add an escape hatch that allows us to update the bundle url for our dev mode case, so we can delete the API.

in this diff, i do some cleanup so the bundle logic is more reusable.

Reviewed By: sammy-SC

Differential Revision: D45937853

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from be396b1 to ad1fcca Compare May 25, 2023 02:00
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from ad1fcca to 27b89cf Compare May 25, 2023 02:05
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from 27b89cf to 6a468ea Compare May 25, 2023 02:14
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 25, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,740,161 +2
android hermes armeabi-v7a 8,051,273 +4
android hermes x86 9,230,367 +2
android hermes x86_64 9,082,002 +3
android jsc arm64-v8a 9,302,098 +0
android jsc armeabi-v7a 8,490,795 +2
android jsc x86 9,363,382 +1
android jsc x86_64 9,619,127 +2

Base commit: d4f6cf1
Branch: main

@philIip philIip force-pushed the export-D45937853 branch from 6a468ea to 6bd919d Compare May 25, 2023 03:09
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from 6bd919d to b39f8d5 Compare May 25, 2023 03:18
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from b39f8d5 to 1b69929 Compare May 25, 2023 03:26
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from 1b69929 to f297d4a Compare May 25, 2023 03:32
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from f297d4a to 96707ad Compare May 25, 2023 03:38
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from 96707ad to 08119b5 Compare May 25, 2023 03:44
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip philIip force-pushed the export-D45937853 branch from 08119b5 to 31ee22a Compare May 25, 2023 05:37
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@philIip @facebook-github-bot
decouple RCTHost bundleURL setter from delegate (facebook#37566)
476bce9 
Summary:
Pull Request resolved: facebook#37566

Changelog: [Internal]

in this diff stack, i remove `- (NSURL *)getBundleURL;` from the bridgeless API.

the reason for this is because the bundle url does not change in the middle of an app session, unless for developer mode, so it's more robust for us to pass it as a dependency.

at the end of the diff stack, i'll add an escape hatch that allows us to update the bundle url for our dev mode case, so we can delete the API.

in this diff, i do some cleanup so the bundle logic is more reusable.

Reviewed By: sammy-SC

Differential Revision: D45937853

fbshipit-source-id: bffe808a26e4cff0de558f6f8fc96f45d80c934d
@philIip philIip force-pushed the export-D45937853 branch from 31ee22a to 476bce9 Compare May 25, 2023 06:33
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937853

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request has been merged in c24b5e9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philIip @facebook-github-bot @analysis-bot