Skip to content

introduce a private API for RCTHost to refresh its bundle url#37567

Closed
philIip wants to merge 3 commits into
facebook:mainfrom
philIip:export-D45937856
Closed

introduce a private API for RCTHost to refresh its bundle url#37567
philIip wants to merge 3 commits into
facebook:mainfrom
philIip:export-D45937856

Conversation

@philIip
Copy link
Copy Markdown
Contributor

@philIip philIip commented May 25, 2023

Summary:
Changelog: [Internal]

in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session.

Reviewed By: cipolleschi

Differential Revision: D45937856

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 4034006 to 88eae3a Compare May 25, 2023 02:03
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 88eae3a to 41c6acf Compare May 25, 2023 02:09
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 41c6acf to fc28138 Compare May 25, 2023 02:18
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 25, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,740,157 -2
android hermes armeabi-v7a 8,051,268 -1
android hermes x86 9,230,362 -3
android hermes x86_64 9,081,998 -1
android jsc arm64-v8a 9,302,095 -3
android jsc armeabi-v7a 8,490,793 +0
android jsc x86 9,363,379 -2
android jsc x86_64 9,619,124 -1

Base commit: d4f6cf1
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from fc28138 to 014ca8d Compare May 25, 2023 02:56
@philIip philIip force-pushed the export-D45937856 branch from 014ca8d to 64e3268 Compare May 25, 2023 03:07
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 64e3268 to 44d52d0 Compare May 25, 2023 03:17
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 44d52d0 to 32a0663 Compare May 25, 2023 03:25
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 32a0663 to bfa0996 Compare May 25, 2023 03:32
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 2c73a75 to fed04ff Compare May 25, 2023 03:47
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from fed04ff to 0a75d64 Compare May 25, 2023 03:54
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 0a75d64 to 9ef8b8a Compare May 25, 2023 05:37
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 9ef8b8a to 1516c84 Compare May 25, 2023 05:44
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from 1516c84 to 97d2ac0 Compare May 25, 2023 05:51
@philIip philIip force-pushed the export-D45937856 branch from 97d2ac0 to bc6e946 Compare May 25, 2023 06:33
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@philIip philIip force-pushed the export-D45937856 branch from bc6e946 to 2276a7d Compare May 25, 2023 06:44
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

philIip and others added 3 commits May 24, 2023 23:48
@philIip @facebook-github-bot
introduce a private API to update the bundle url
2138403 
Differential Revision: D45937853

fbshipit-source-id: 9a908a4e83b10c0633ed97ed76e3781f11e5467f
@philIip @facebook-github-bot
pass in bundle url as a dependency of RCTHost
f72fb63 
Differential Revision: D45937855

fbshipit-source-id: 3c83307dc157e82f2de3b7c0f08c191e0ece0603
@philIip @facebook-github-bot
introduce a private API for RCTHost to refresh its bundle url (facebo…
3f71889 
…ok#37567)

Summary:
Pull Request resolved: facebook#37567

Changelog: [Internal]

in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session.

Reviewed By: cipolleschi

Differential Revision: D45937856

fbshipit-source-id: 088ac019ee61baffae1f59a0b91eb903da63531e
@philIip philIip force-pushed the export-D45937856 branch from 2276a7d to 3f71889 Compare May 25, 2023 06:52
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937856

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request has been merged in 992c45c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philIip @facebook-github-bot @analysis-bot