Skip to content

pass in bundle url as a dependency of RCTHost#37568

Closed
philIip wants to merge 2 commits into
facebook:mainfrom
philIip:export-D45937855
Closed

pass in bundle url as a dependency of RCTHost#37568
philIip wants to merge 2 commits into
facebook:mainfrom
philIip:export-D45937855

Conversation

@philIip
Copy link
Copy Markdown
Contributor

@philIip philIip commented May 25, 2023

Summary:
Changelog: [Internal]

since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of getBundleURL from the react host's delegate.

Reviewed By: sammy-SC

Differential Revision: D45937855

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from 39761f0 to 09cb193 Compare May 25, 2023 02:04
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from 09cb193 to b04f408 Compare May 25, 2023 02:12
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from b04f408 to 09a60ed Compare May 25, 2023 02:21
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 25, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,740,156 -3
android hermes armeabi-v7a 8,051,267 -2
android hermes x86 9,230,363 -2
android hermes x86_64 9,081,996 -3
android jsc arm64-v8a 9,302,094 -4
android jsc armeabi-v7a 8,490,790 -3
android jsc x86 9,363,375 -6
android jsc x86_64 9,619,124 -1

Base commit: d4f6cf1
Branch: main

@philIip philIip force-pushed the export-D45937855 branch from 09a60ed to be522d9 Compare May 25, 2023 03:09
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from be522d9 to 50dd7ae Compare May 25, 2023 03:17
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from 50dd7ae to 275af53 Compare May 25, 2023 03:25
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from 275af53 to c32a070 Compare May 25, 2023 03:33
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from c32a070 to c361176 Compare May 25, 2023 03:42
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from c361176 to 804090c Compare May 25, 2023 03:49
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@philIip philIip force-pushed the export-D45937855 branch from 804090c to b7e948c Compare May 25, 2023 05:37
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

philIip and others added 2 commits May 24, 2023 23:34
@philIip @facebook-github-bot
introduce a private API to update the bundle url
3c92cf1 
Differential Revision: D45937853

fbshipit-source-id: 0df39055ee8f75329376a28f414410548badd3ce
@philIip @facebook-github-bot
pass in bundle url as a dependency of RCTHost (facebook#37568)
bc399fa 
Summary:
Pull Request resolved: facebook#37568

Changelog: [Internal]

since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate.

Reviewed By: sammy-SC

Differential Revision: D45937855

fbshipit-source-id: 86c59a826d2121441f1fea55e857e264bfcbafb6
@philIip philIip force-pushed the export-D45937855 branch from b7e948c to bc399fa Compare May 25, 2023 06:36
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request was exported from Phabricator. Differential Revision: D45937855

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 25, 2023

This pull request has been merged in fb64bbf.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philIip @facebook-github-bot @analysis-bot