use TripleEqual instead of doubleEqual when comparing two string#37673
Closed
aymane-missouri-nw wants to merge 1 commit intofacebook:mainfrom
Closed
use TripleEqual instead of doubleEqual when comparing two string#37673aymane-missouri-nw wants to merge 1 commit intofacebook:mainfrom
aymane-missouri-nw wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: fd9e295 |
aymane-missouri-nw
force-pushed
the
enhance/use-tripleEq-insteadOf-doubleEq
branch
from
7a11324 to
6bf8fc7
Compare
cortinico
approved these changes
Jun 5, 2023
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 805604d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is generally recommended to use "===" instead of "==" when comparing two strings
Test plan
Changelog:
[Internal] [Changed] - use TripleEqual instead of doubleEqual when comparing two string