Skip to content

Delete validation in set-rn-version#37814

Closed
lunaleaps wants to merge 2 commits into
facebook:mainfrom
lunaleaps:export-D46584771
Closed

Delete validation in set-rn-version#37814
lunaleaps wants to merge 2 commits into
facebook:mainfrom
lunaleaps:export-D46584771

Conversation

@lunaleaps
Copy link
Copy Markdown
Contributor

@lunaleaps lunaleaps commented Jun 10, 2023

Summary: Changelog: [Internal] - deleting file validation, do we need this?

Differential Revision: D46584771

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 10, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 10, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 10, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,670 -1
android hermes armeabi-v7a 8,070,240 +2
android hermes x86 9,250,266 -1
android hermes x86_64 9,099,408 +0
android jsc arm64-v8a 9,318,873 +3
android jsc armeabi-v7a 8,508,777 +3
android jsc x86 9,382,363 +0
android jsc x86_64 9,635,609 +1

Base commit: af99a68
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

Luna Wei and others added 2 commits June 14, 2023 07:32
@facebook-github-bot
Fix set-rn-version
f8ca9e8 
Summary: Changelog: [Internal] - Fix `saveFiles` in set-rn-version, incorrect function invoke

Differential Revision: D46582168

fbshipit-source-id: 0fc72b3167adaf3588a0606e53f990bf2eeb4440
@lunaleaps @facebook-github-bot
Delete validation in set-rn-version (facebook#37814)
222436e 
Summary:
Pull Request resolved: facebook#37814

Changelog: [Internal] - deleting file validation, do we need this?

Reviewed By: NickGerleman

Differential Revision: D46584771

fbshipit-source-id: d65b1e67220f2bf436f8ba8b38c9be05278c2f07
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46584771

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 14, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2023

This pull request has been merged in be34852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lunaleaps @facebook-github-bot @analysis-bot