Untangle dependency loop in virtualized-lists#37912
Closed
rshest wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
Base commit: c5496fd |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
Summary: Pull Request resolved: facebook#37912 # Changelog: [Internal] - I've noticed bundler spamming with cyclical dependency warnings when working on FB4A. This gets rid of the unneeded two-way dependency between `ListMetricsAggregator <-> VirtualizeUtils`. Reviewed By: NickGerleman Differential Revision: D46761080 fbshipit-source-id: e34af7070448974b13c1b715969a3e6b1f78d495
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46761080 |
|
This pull request was successfully merged by @rshest in 92525ef. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
I've noticed bundler spamming with cyclical dependency warnings when working on FB4A.
This gets rid of the unneeded two-way dependency between
ListMetricsAggregator <-> VirtualizeUtils.Differential Revision: D46761080