Remove duplication in rn-tester react-native.config.js file#37978
Closed
huntie wants to merge 1 commit into
Closed
Remove duplication in rn-tester react-native.config.js file#37978huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46859698 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46859698 |
Base commit: 259a316 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46859698 |
…#37978) Summary: Pull Request resolved: facebook#37978 Tweaks `react-native.config.js` files to remove duplication. `rn-tester` now references framework-included config from `react-native` (ahead of making config additions to this entry point). As far as I can tell (from historic diff context), the presence of `packages/rn-tester/react-native.config.js` is a special case, due to the CLI's config discovery algorithm, and this file needs to remain a complete config. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D46859698 fbshipit-source-id: 71e67d273f90974fedaa02676f4b3fda21ec25df
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46859698 |
Contributor
|
This pull request has been merged in d1882c3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tweaks
react-native.config.jsfiles to remove duplication.rn-testernow references framework-included config fromreact-native(ahead of making config additions to this entry point).As far as I can tell (from historic diff context), the presence of
packages/rn-tester/react-native.config.jsis a special case, due to the CLI's config discovery algorithm, and this file needs to remain a complete config.Changelog: [Internal]
Reviewed By: hoxyq
Differential Revision: D46859698