Skip to content

Auto close issue if version is too old#38041

Closed
Pranav-yadav wants to merge 1 commit intofacebook:mainfrom
Pranav-yadav:patch-1
Closed

Auto close issue if version is too old#38041
Pranav-yadav wants to merge 1 commit intofacebook:mainfrom
Pranav-yadav:patch-1

Conversation

@Pranav-yadav
Copy link
Copy Markdown
Contributor

@Pranav-yadav Pranav-yadav commented Jun 23, 2023

Summary:

Auto-close an issue when the version of React Native specified is TOO OLD.
Applies Type: Too Old Version label and closes such issues using actOnLabel workflow.

Changelog:

[GENERAL] [ADDED] - Auto close issue if version is too old.

Test Plan:

  • Should auto-close an issue with Type: Too Old Version label

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2023
@Pranav-yadav

This comment was marked as resolved.

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 23, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,001,855 +3
android hermes armeabi-v7a 8,255,912 +4
android hermes x86 9,510,995 +3
android hermes x86_64 9,356,877 +5
android jsc arm64-v8a 9,614,916 +4
android jsc armeabi-v7a 8,741,552 -2
android jsc x86 9,701,868 +3
android jsc x86_64 9,948,431 +3

Base commit: 1706066
Branch: main

@Pranav-yadav Pranav-yadav marked this pull request as ready for review June 30, 2023 08:36
@Pranav-yadav Pranav-yadav changed the title Auto close issue on Unsupported Version label Auto close issue if version is too old Jun 30, 2023
@Pranav-yadav
Copy link
Copy Markdown
Contributor Author

@cortinico any changes required from my side.
P.S.: rebased.

@Pranav-yadav Pranav-yadav requested review from cortinico and kelset July 8, 2023 14:54
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 10, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 28dfdb2.

@cortinico
Copy link
Copy Markdown
Contributor

@Pranav-yadav the UI of this comment is odd:
#38313 (comment)

Could you follow up?

@Pranav-yadav
Copy link
Copy Markdown
Contributor Author

Hey, Nico!
Thanks for merging.

Could you follow up?

Sure. Will do a follow-up.

P.S. Actually started with my first job, and you know the first two weeks are... 😊

@Pranav-yadav Pranav-yadav deleted the patch-1 branch July 21, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants