Monorepo Jest - remove now unnecessary Babel registration#38146
Closed
robhogan wants to merge 3 commits into
Closed
Monorepo Jest - remove now unnecessary Babel registration#38146robhogan wants to merge 3 commits into
robhogan wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47162728 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ flow-typed/npm/babel-traverse_v7.x.x.js line 94 – 'ft-flow/no-dupe-keys' rule is disabled but never reported. (eslint-comments/no-unused-disable)
Differential Revision: D47153654 fbshipit-source-id: 9f5d55e80fe053e0f3322c8b2933d7ea13b1f4f3
Differential Revision: D47154206 fbshipit-source-id: befbb8d19f8648142d4ed16ea0566f4e0ea130f7
…8146) Summary: Pull Request resolved: facebook#38146 Now that `metro-react-native-babel-transformer` may be loaded from source without transformation, we can remove this workaround / potential footgun. Jest uses Babel imperatively and doesn't rely on registration (require hooks), so registering within the preprocessor potentially conflicts and has caused problems before. This just tidies up some complexity we don't need. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D47162728 fbshipit-source-id: a4357f25ae052cb179cb493566127a018601b407
robhogan
force-pushed
the
export-D47162728
branch
from
ffcdc11 to
21c0bc6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47162728 |
Contributor
|
This pull request has been merged in 971bb81. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that
metro-react-native-babel-transformermay be loaded from source without transformation, we can remove this workaround / potential footgun.Jest uses Babel imperatively and doesn't rely on registration (require hooks), so registering within the preprocessor potentially conflicts and has caused problems before. This just tidies up some complexity we don't need.
Changelog: [Internal]
Differential Revision: D47162728