Update startup perf api to accept undefined/null values#38323
Closed
ryancat wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
Base commit: 10feddc |
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 17, 2023
Summary: Pull Request resolved: facebook#38323 This change makes the returned values from `performance.reactNativeStartupTiming` to accept null or undefined. This is done as some platforms may not have certain startup timing information, and as a default value, it's discussed that null/undefined is better than zero. - Use `unorderedMap` instead of custom timing object for the C++ native module return value - Use `std::nan` as initialized value for unset doubles - Update examples to reflect the latest changes Changelog: [General][Internal] - Make the return values for `reactNativeStartupTiming` possible to be null or undefined Reviewed By: mdvacca Differential Revision: D43885535 fbshipit-source-id: 313d91e9f3dff94399c54ded16f9a364739021ca
ryancat
force-pushed
the
export-D43885535
branch
from
c4614fa to
1d4b7b1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
ryancat
force-pushed
the
export-D43885535
branch
from
1d4b7b1 to
05d9a86
Compare
github-actions
Bot
added
the
Needs: Repro
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
ryancat
force-pushed
the
export-D43885535
branch
from
05d9a86 to
5d9d7bf
Compare
ryancat
force-pushed
the
export-D43885535
branch
from
5d9d7bf to
8b4722a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
ryancat
force-pushed
the
export-D43885535
branch
from
8b4722a to
40ab127
Compare
Summary: Pull Request resolved: facebook#38323 This change makes the returned values from `performance.reactNativeStartupTiming` to accept null or undefined. This is done as some platforms may not have certain startup timing information, and as a default value, it's discussed that null/undefined is better than zero. - Use `unorderedMap` instead of custom timing object for the C++ native module return value - Use `std::nan` as initialized value for unset doubles - Update examples to reflect the latest changes Changelog: [General][Internal] - Make the return values for `reactNativeStartupTiming` possible to be null or undefined Reviewed By: mdvacca Differential Revision: D43885535 fbshipit-source-id: 791fb02d653f7da85ba134ae7def5b8764cc97d9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43885535 |
ryancat
force-pushed
the
export-D43885535
branch
from
40ab127 to
f418427
Compare
Contributor
|
This pull request has been merged in 17f957a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change makes the returned values from
performance.reactNativeStartupTimingto accept null or undefined. This is done as some platforms may not have certain startup timing information, and as a default value, it's discussed that null/undefined is better than zero.unorderedMapinstead of custom timing object for the C++ native module return valuestd::nanas initialized value for unset doublesChangelog:
[General][Internal] - Make the return values for
reactNativeStartupTimingpossible to be null or undefinedReviewed By: mdvacca
Differential Revision: D43885535