fix: unified Share Action types#38351
Conversation
|
love it |
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@juniorklawa can you rebase and retrigger the CI jobs? |
f4281e7 to
fa75970
Compare
Base commit: f6c417c |
|
@philIip sorry, i got lost here, should i do something else? |
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
nope should all be done! thanks for your contribution! |
|
This pull request was successfully merged by @juniorklawa in caa8dbf. When will my fix make it into a release? | Upcoming Releases |
Summary:
This pull request simplifies the type and fixes a TypeScript object destructuring problem by combining the ShareSharedAction and ShareDismissedAction types into a single ShareAction type. Enabling proper access to the activityType property without TypeScript errors.
Changelog:
[INTERNAL] [FIXED] - Unified ShareSharedAction and ShareDismissedAction into ShareAction. Resolved TypeScript issue with object destructuring.
Test Plan:
With the current typing:

With the proposed solution:
