Skip to content

fix: unified Share Action types#38351

Closed
juniorklawa wants to merge 4 commits into
facebook:mainfrom
juniorklawa:feat/share-action-type
Closed

fix: unified Share Action types#38351
juniorklawa wants to merge 4 commits into
facebook:mainfrom
juniorklawa:feat/share-action-type

Conversation

@juniorklawa
Copy link
Copy Markdown
Contributor

Summary:

This pull request simplifies the type and fixes a TypeScript object destructuring problem by combining the ShareSharedAction and ShareDismissedAction types into a single ShareAction type. Enabling proper access to the activityType property without TypeScript errors.

Changelog:

[INTERNAL] [FIXED] - Unified ShareSharedAction and ShareDismissedAction into ShareAction. Resolved TypeScript issue with object destructuring.

Test Plan:

With the current typing:
image

With the proposed solution:
image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 14, 2023
@philIip
Copy link
Copy Markdown
Contributor

philIip commented Jul 17, 2023

love it

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Comment thread packages/react-native/Libraries/Share/Share.d.ts
@juniorklawa juniorklawa requested a review from NickGerleman July 19, 2023 13:28
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions github-actions Bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 19, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@philIip
Copy link
Copy Markdown
Contributor

philIip commented Jul 20, 2023

@juniorklawa can you rebase and retrigger the CI jobs?

@cortinico cortinico removed the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023
@juniorklawa juniorklawa force-pushed the feat/share-action-type branch from f4281e7 to fa75970 Compare July 20, 2023 16:24
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 20, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,842,748 +2
android hermes armeabi-v7a 8,152,150 +3
android hermes x86 9,348,437 +2
android hermes x86_64 9,191,270 +1
android jsc arm64-v8a 9,454,434 +3
android jsc armeabi-v7a 8,635,758 +4
android jsc x86 9,537,428 +2
android jsc x86_64 9,780,791 +2

Base commit: f6c417c
Branch: main

@github-actions github-actions Bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023
@juniorklawa
Copy link
Copy Markdown
Contributor Author

@philIip sorry, i got lost here, should i do something else?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@philIip
Copy link
Copy Markdown
Contributor

philIip commented Jul 20, 2023

nope should all be done! thanks for your contribution!

@github-actions github-actions Bot added the Merged This PR has been merged. label Jul 20, 2023
@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @juniorklawa in caa8dbf.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants