Skip to content

Introduce SampleLegacyModule example in RNTester#38539

Closed
RSNara wants to merge 1 commit into
facebook:mainfrom
RSNara:export-D47529295
Closed

Introduce SampleLegacyModule example in RNTester#38539
RSNara wants to merge 1 commit into
facebook:mainfrom
RSNara:export-D47529295

Conversation

@RSNara
Copy link
Copy Markdown
Contributor

@RSNara RSNara commented Jul 20, 2023

Summary:
We will use this example to:

  • Showcase legacy module support in the TurboModule system in RNTester
  • E2E test legacy module support in the TurboModule system

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D47529295

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 20, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 20, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@github-actions github-actions Bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 20, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,960,039 +3,867
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,550,597 +1,475
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 489d890
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 20, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from f70f33c to e0a75fc Compare July 20, 2023 21:44
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from e0a75fc to c3911ad Compare July 21, 2023 17:49
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from c3911ad to b317cf2 Compare July 21, 2023 17:57
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from b317cf2 to 07c2751 Compare July 21, 2023 19:08
@RSNara RSNara force-pushed the export-D47529295 branch from 07c2751 to 473236e Compare July 21, 2023 19:17
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from 473236e to cb08d30 Compare July 21, 2023 19:27
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from cb08d30 to b028064 Compare July 24, 2023 18:38
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 24, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch from b028064 to a894126 Compare July 24, 2023 21:02
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 24, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 24, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara RSNara force-pushed the export-D47529295 branch 2 times, most recently from bfda4f6 to 560a923 Compare July 26, 2023 23:02
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 26, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@cortinico cortinico removed the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Aug 1, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@RSNara @facebook-github-bot
Introduce SampleLegacyModule example in RNTester (facebook#38539)
ea0c9da 
Summary:
Pull Request resolved: facebook#38539

We will use this example to:
- Showcase legacy module support in the TurboModule system in RNTester
- E2E test legacy module support in the TurboModule system

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D47529295

fbshipit-source-id: d6a06b07438738e8a30b702151abcc49707c3ec2
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 21, 2023

This pull request was exported from Phabricator. Differential Revision: D47529295

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 22, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 22, 2023

This pull request has been merged in 1456592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara @facebook-github-bot @analysis-bot @cortinico