Skip to content

Use version catalog to consolidate versions for JVM dependencies#38836

Closed
cortinico wants to merge 1 commit into
mainfrom
nc/version-catalog
Closed

Use version catalog to consolidate versions for JVM dependencies#38836
cortinico wants to merge 1 commit into
mainfrom
nc/version-catalog

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:

As we had version numbers scattered all over the places, I'm consolidating them to use a version catalog: https://docs.gradle.org/current/userguide/platforms.html

Changelog:

[INTERNAL] - Use version catalog to consolidate versions for JVM dependencies

Test Plan:

CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 8, 2023
@cortinico cortinico force-pushed the nc/version-catalog branch from 138d39c to b1097f3 Compare August 8, 2023 12:01
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,894,956 +6
android hermes armeabi-v7a 7944390 n/a
android hermes x86 9293277 n/a
android hermes x86_64 9194702 n/a
android jsc arm64-v8a 9,486,854 +3
android jsc armeabi-v7a 8429234 n/a
android jsc x86 9471343 n/a
android jsc x86_64 9785486 n/a

Base commit: 501c80b
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2023

This pull request was successfully merged by @cortinico in e563f0f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Aug 8, 2023
@cortinico cortinico deleted the nc/version-catalog branch June 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants