Introduce a build_android step#38848
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
cortinico
force-pushed
the
export-D48148418
branch
from
453aa3f to
9939cf8
Compare
cortinico
force-pushed
the
export-D48148418
branch
from
9939cf8 to
c04f956
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
Base commit: e2ef6b9 |
|
This pull request was successfully merged by @cortinico in c04f956038f08fd7c3df1e560bafb152b30ca08d. When will my fix make it into a release? | Upcoming Releases |
cortinico
force-pushed
the
export-D48148418
branch
3 times, most recently
from
d024b05 to
f3c773e
Compare
cortinico
force-pushed
the
export-D48148418
branch
from
f877af9 to
3bf8c12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
cortinico
force-pushed
the
export-D48148418
branch
from
3bf8c12 to
7dbbb33
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
cortinico
force-pushed
the
export-D48148418
branch
from
7dbbb33 to
36e0eb2
Compare
Summary: Pull Request resolved: facebook#38848 In order to parallelize the Android CI, I've moved most of the building to a `build_android` step which executes before the `build_npm_package` step. As currently, building Hermes for Android is on the critical path, this should reduce much of the execution time on CI. Changelog: [Internal] [Changed] - Introduce a build_android step Reviewed By: mdvacca Differential Revision: D48148418 fbshipit-source-id: 647d6e299991fe443134081c8a149962223c308a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48148418 |
cortinico
force-pushed
the
export-D48148418
branch
from
36e0eb2 to
481e24a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In order to parallelize the Android CI, I've moved most of the building to a
build_androidstep which executes before thebuild_npm_packagestep.As currently, building Hermes for Android is on the critical path, this should reduce much of the execution time on CI.
Changelog:
[Internal] [Changed] - Introduce a build_android step
Differential Revision: D48148418