Add init react runtime start time in performance API (#38328)#38858
Closed
ryancat wants to merge 1 commit into
Closed
Add init react runtime start time in performance API (#38328)#38858ryancat wants to merge 1 commit into
ryancat wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47941110 |
Base commit: 66d6384 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47941110 |
ryancat
force-pushed
the
export-D47941110
branch
from
bd4523f to
3118904
Compare
Summary: Pull Request resolved: facebook#38858 Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: rshest Differential Revision: D47941110 fbshipit-source-id: 1a589d5e598352a97e5dfacb8ae14a01c46f238a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47941110 |
ryancat
force-pushed
the
export-D47941110
branch
from
3118904 to
37b2038
Compare
Contributor
|
This pull request has been merged in 5063871. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the two extra markers
initializeRuntimeStartandinitializeRuntimeEndto the startup performance API. The runtime start time matches the existing android markerGET_REACT_INSTANCE_MANAGER_START, which is the first marker we have on the RN android app.Changelog:
[Android][Added] - Add
performance.reactNativeStartupTiming.initializeRuntimeStartandperformance.reactNativeStartupTiming.initializeRuntimeEndAPIReviewed By: rshest
Differential Revision: D47941110