Cleanup and scope all the Gradle Properties#38885
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48188310 |
Base commit: 0279a70 |
cortinico
force-pushed
the
export-D48188310
branch
from
f3280a5 to
46b492c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48188310 |
cortinico
force-pushed
the
export-D48188310
branch
from
46b492c to
d01bd8c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48188310 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48188310 |
cortinico
force-pushed
the
export-D48188310
branch
from
d01bd8c to
59850ae
Compare
Summary: Pull Request resolved: facebook#38885 We do have several Gradle Properties that are used to configure the build. I've refactored them all and moved them inside the PropertyUtils file: https://github.com/facebook/react-native/blob/main/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PropertyUtils.kt Specifically properties should be 'scoped' under `react.` if public, and `react.internal.` if for internal usage. Property that I cleaned up are: - REACT_NATIVE_MAVEN_LOCAL_REPO becomes react.internal.mavenLocalRepo - REACT_WINDOWS_BASH becomes react.internal.windowsBashPath - GROUP becomes react.internal.publishingGroup I've also added support for scoping for public properties with backward compat (so both the scoped and unscoped properties are accepted): - react.newArchEnabled - react.hermesEnabled - react.nativeArchitectures Changelog: [Android] [Changed] - Cleanup and scope all the Gradle Properties Reviewed By: mdvacca Differential Revision: D48188310 fbshipit-source-id: 2d791d4d2c2e48957e62c0ce4bbc0a12d4379465
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48188310 |
cortinico
force-pushed
the
export-D48188310
branch
from
59850ae to
2c7bb3f
Compare
|
This pull request was successfully merged by @cortinico in 1a765b6. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We do have several Gradle Properties that are used to configure the build.
I've refactored them all and moved them inside the PropertyUtils file:
https://github.com/facebook/react-native/blob/main/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PropertyUtils.kt
Specifically properties should be 'scoped' under
react.if public, andreact.internal.if for internal usage.Property that I cleaned up are:
I've also added support for scoping for public properties with backward compat (so both the scoped and unscoped properties are accepted):
Changelog:
[Android] [Changed] - Cleanup and scope all the Gradle Properties
Differential Revision: D48188310