Introduce react.internal.useHermesNightly#38886

Closed

cortinico wants to merge 1 commit into

facebook:mainfrom

cortinico:export-D48188769

Contributor

cortinico commented Aug 9, 2023

Summary:
This change introduces a property called react.internal.useHermesNightly

This allows users building RN-Tester or just ReactAndroid to fetch Hermes from the latest
nightly, without having to build it from source.

The change could be useful to speedup local development, but it should not be enabled on CI or when doing releases.

Changelog:
[Internal] [Changed] - Introduce react.internal.useHermesNightly

Differential Revision: D48188769

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

1 similar comment

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 35aa19a to d9f3bf2 Compare

August 9, 2023 15:06

analysis-bot commented Aug 9, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,947,553	+18
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,541,277	-10
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 1a765b6
Branch: main

cortinico force-pushed the export-D48188769 branch from d9f3bf2 to d6a0403 Compare

August 9, 2023 16:45

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from d6a0403 to 80d0deb Compare

August 9, 2023 20:19

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 80d0deb to 1824da3 Compare

August 9, 2023 21:31

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 1824da3 to 2da0a4b Compare

August 10, 2023 10:53

Contributor

facebook-github-bot commented Aug 10, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 2da0a4b to eef5da6 Compare

August 10, 2023 11:04

Contributor

facebook-github-bot commented Aug 10, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

1 similar comment

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from eef5da6 to bcf6358 Compare

August 11, 2023 08:17

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from bcf6358 to 0fd0bef Compare

August 11, 2023 08:21

cortinico mentioned this pull request

☂️ Help us Kotlin-ify React Native tests - Round 2 #38825

Closed

27 tasks

Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 0fd0bef to 1ec932e Compare

August 14, 2023 04:52

Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 1ec932e to 04c6808 Compare

August 14, 2023 04:58


          Introduce react.internal.useHermesNightly (facebook#38886)

88eb340

Summary:
Pull Request resolved: facebook#38886

This change introduces a property called `react.internal.useHermesNightly`

This allows users building RN-Tester or just ReactAndroid to fetch Hermes from the latest
nightly, without having to build it from source.

The change could be useful to speedup local development, but it should not be enabled on CI or when doing releases.

Changelog:
[Internal] [Changed] - Introduce react.internal.useHermesNightly

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48188769

fbshipit-source-id: 5ba6d82e03acd5fe7d9f581be059272bc93be8a8

Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188769

cortinico force-pushed the export-D48188769 branch from 04c6808 to 88eb340 Compare

August 14, 2023 07:01

github-actions Bot commented Aug 14, 2023

This pull request was successfully merged by @cortinico in 54033fd.

^{When will my fix make it into a release? | Upcoming Releases}

github-actions Bot added the Merged label

facebook-github-bot closed this in

54033fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner