Mitigate flakiness in iOS#38894
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
Summary: This Parameter was false and never set to true. Also, we don't know what that code does and it was not used for more than a year. ## Changelog: [Internal] - Removing not executed code. Differential Revision: D48189139 fbshipit-source-id: 66236e2df86056bf395b75cacc48c169013025e6
Summary: This diff introduces a script `run_with_retry` that we can apply to single commands in order to mitigate the flakiness. This can be useful when networking is involved, to retry installing some dependencies, or for example with some e2e/integration tests. The diff applies this rerun to the iOS tests so we mitigate failures in CI. ## Changelog: [Internal] - Add script to retry CI steps and mitigate iOS flakyness. Differential Revision: D48189365 fbshipit-source-id: 944aec018afd23c642efee0ca40ef5aafc254cd7
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48189365 |
Base commit: e14d27c |
Contributor
|
This pull request has been merged in ad18f81. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces a script
run_with_retrythat we can apply to single commands in order to mitigate the flakiness.This can be useful when networking is involved, to retry installing some dependencies, or for example with some e2e/integration tests.
The diff applies this rerun to the iOS tests so we mitigate failures in CI.
Changelog:
[Internal] - Add script to retry CI steps and mitigate iOS flakyness.
Differential Revision: D48189365