Fix warnings for Gradle 9#38927
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48231760 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48231760 |
cortinico
force-pushed
the
export-D48231760
branch
from
ace0f72 to
599a546
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48231760 |
cortinico
force-pushed
the
export-D48231760
branch
from
599a546 to
ea0d2e7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48231760 |
cortinico
force-pushed
the
export-D48231760
branch
from
ea0d2e7 to
0637388
Compare
Base commit: 8fa584f |
Summary: Pull Request resolved: facebook#38927 I've done a pass and fixed most of the warnings for Gradle 9: - project.buildDir is deprecated in favor of project.layout.buildDirectory - I've updated 3rd party Gradle Plugins that we depend on There are still two warnings which are outside of our control: 1. One is inside AGP and will be fixed with AGP 8.2 - Source https://issuetracker.google.com/issues/279306626 2. Another one is inside nexus-publish and should ideally be fixed by 2.0 gradle/gradle#25206 Will bump the release once it's out Changelog: [Internal] [Changed] - Fix warnings for Gradle 9 Reviewed By: mdvacca Differential Revision: D48231760 fbshipit-source-id: d6df387e16377aca8d09cbc3a3dc2c92e88802ef
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48231760 |
cortinico
force-pushed
the
export-D48231760
branch
from
0637388 to
3866cbe
Compare
|
This pull request was successfully merged by @cortinico in 41af21b. When will my fix make it into a release? | Upcoming Releases |
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
Summary: Pull Request resolved: facebook#38927 I've done a pass and fixed most of the warnings for Gradle 9: - project.buildDir is deprecated in favor of project.layout.buildDirectory - I've updated 3rd party Gradle Plugins that we depend on There are still two warnings which are outside of our control: 1. One is inside AGP and will be fixed with AGP 8.2 - Source https://issuetracker.google.com/issues/279306626 2. Another one is inside nexus-publish and should ideally be fixed by 2.0 gradle/gradle#25206 Will bump the release once it's out Changelog: [Internal] [Changed] - Fix warnings for Gradle 9 Reviewed By: mdvacca Differential Revision: D48231760 fbshipit-source-id: 27d704324ea33cfc8aa0164fa437b80aab425960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've done a pass and fixed most of the warnings for Gradle 9:
There are still two warnings which are outside of our control:
Changelog:
[Internal] [Changed] - Fix warnings for Gradle 9
Differential Revision: D48231760