Skip to content

Replace Metro stdout check with dep_graph_loaded event#38960

Closed
huntie wants to merge 4 commits into
facebook:mainfrom
huntie:export-D48188228
Closed

Replace Metro stdout check with dep_graph_loaded event#38960
huntie wants to merge 4 commits into
facebook:mainfrom
huntie:export-D48188228

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Aug 11, 2023

Summary:
Code cleanup following cli-plugin-metro import.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48188228

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 11, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 11, 2023 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against e6c4092

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Aug 11, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,947,330 +35
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,540,943 +77
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 857bc05
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

huntie and others added 4 commits August 15, 2023 02:30
@huntie @facebook-github-bot
Upgrade CLI and Metro, update status check refs
d729ed3 
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 3f1b607cd756c8a20c41cdb7a49ba79dfa173821
@huntie @facebook-github-bot
Sync latest cli-plugin-metro changes
97155dc 
Differential Revision: D48066179

fbshipit-source-id: 4d4a6ba4bec2d2495835fb431cacd60d002f547a
@facebook-github-bot
Convert cli-commands to Flow strict
40f4ee8 
Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066180

fbshipit-source-id: 305f440d7b3f1f764e3e68c1b017b0c357e99b38
@huntie @facebook-github-bot
Replace Metro stdout check with dep_graph_loaded event (facebook#38960)
e6c4092 
Summary:
Pull Request resolved: facebook#38960

Code cleanup following `cli-plugin-metro` import.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48188228

fbshipit-source-id: d9c748c7f315bea38008da0f177d218e6c35b2bf
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 15, 2023

This pull request was exported from Phabricator. Differential Revision: D48188228

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 15, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 15, 2023

This pull request has been merged in 2f3fcb6.

@huntie huntie deleted the export-D48188228 branch August 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntie @facebook-github-bot @analysis-bot