Publish dSYM to Maven when doing a release#38992
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48309198 |
Base commit: 857bc05 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48309198 |
cipolleschi
force-pushed
the
export-D48309198
branch
from
bf7b2b4 to
b3b4253
Compare
Summary: Pull Request resolved: facebook#38983 Creates the dSYMs and store them as artifact in CircleCI ## Changelog: [Internal] - Create the dSYM archive and upload it to CircleCI Reviewed By: cortinico Differential Revision: D48301851 fbshipit-source-id: 736fb9fd0813171b8051c05facdd61645a44862d
Summary: Pull Request resolved: facebook#38992 This Diff publishes the Hermes dSYMs to Maven while doing a release. These were missing and so the Stack traces can't be fully symbolicated when a crash occurs. ## Changelog: [Internal] - Publish dSYM to Maven Reviewed By: cortinico Differential Revision: D48309198 fbshipit-source-id: 8fd59b1d9ddecc01784003d93888245c7869fd27
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48309198 |
cipolleschi
force-pushed
the
export-D48309198
branch
from
b3b4253 to
5eafdf7
Compare
Contributor
|
This pull request has been merged in 540c41b. |
cipolleschi
added a commit
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: #38992 This Diff publishes the Hermes dSYMs to Maven while doing a release. These were missing and so the Stack traces can't be fully symbolicated when a crash occurs. ## Changelog: [Internal] - Publish dSYM to Maven Reviewed By: cortinico Differential Revision: D48309198 fbshipit-source-id: a5514e544587daadd0a0d7614f25a30fccd16a5b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff publishes the Hermes dSYMs to Maven while doing a release.
These were missing and so the Stack traces can't be fully symbolicated when a crash occurs.
Changelog:
[Internal] - Publish dSYM to Maven
Differential Revision: D48309198