Skip to content

Add retry mechanism to test_e2e_android to reduce flakyness#39068

Closed
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/add_retry_to_e2e
Closed

Add retry mechanism to test_e2e_android to reduce flakyness#39068
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/add_retry_to_e2e

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

Summary:

We figured that android e2e tests are a bit flakier than needed. This change add a retry mechanism to rerun the tests up to 3 times in order to try and reduce the flakyness there.

Changelog:

[Internal] - Add retry to Android e2e tests

Test Plan:

CircleCI stays green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 18, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,948,880 -39
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,542,181 -18
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2ec920e
Branch: main

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @cipolleschi in c326ec0.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Aug 18, 2023
@cortinico cortinico deleted the cipolleschi/add_retry_to_e2e branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants