Resolve absolute paths of Babel presets/plugins in Node build config#39079
Closed
motiz88 wants to merge 1 commit into
Closed
Resolve absolute paths of Babel presets/plugins in Node build config#39079motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48469386 |
…acebook#39079) Summary: Pull Request resolved: facebook#39079 Changelog: [Internal] The Babel config for Node packages in the RN repo, added in D47760330 / D48312463, relies on [name normalization](https://babeljs.io/docs/options#name-normalization) to resolve the Babel presets and plugins that it references. This works for OSS but can cause other integrations to fail to resolve the packages, depending on the details of how they're installed. Here we eagerly resolve the packages when constructing the Babel config. Reviewed By: huntie Differential Revision: D48469386 fbshipit-source-id: 72750c93fbab5ca341f05e4dc977ac28fb665585
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48469386 |
motiz88
force-pushed
the
export-D48469386
branch
from
d3c7045 to
7ba0dc3
Compare
|
This pull request was successfully merged by @motiz88 in be469c1. When will my fix make it into a release? | Upcoming Releases |
Base commit: 3dbb759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
The Babel config for Node packages in the RN repo, added in D47760330 / D48312463, relies on name normalization to resolve the Babel presets and plugins that it references. This works for OSS but can cause other integrations to fail to resolve the packages, depending on the details of how they're installed. Here we eagerly resolve the packages when constructing the Babel config.
Reviewed By: huntie
Differential Revision: D48469386