Check if cmake is installed on RNTester#39208
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48821932 |
Base commit: 40dca3f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48821932 |
cipolleschi
force-pushed
the
export-D48821932
branch
from
b429941 to
c7deda8
Compare
Summary: Pull Request resolved: facebook#39208 To properly build RNTester for iOS, we need cmake installed. This small change check whether Cmake is present in the system. If not, it tries to install it using `brew` if that's available. Otherwise, it exits with an error message asking to install cmake. ## Changelog: [Internal] - Check whether Cmake is present for RNTester Reviewed By: dmytrorykun Differential Revision: D48821932 fbshipit-source-id: feb43108b03a165ab4292bfb0594d299b9213091
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48821932 |
cipolleschi
force-pushed
the
export-D48821932
branch
from
c7deda8 to
1665b5e
Compare
Generated by 🚫 dangerJS against c7deda8f946b32c8a13d18d374e75b13545c671b |
|
This pull request was successfully merged by @cipolleschi in 2423342. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in 2423342. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To properly build RNTester for iOS, we need cmake installed.
This small change check whether Cmake is present in the system. If not, it tries to install it using
brewif that's available.Otherwise, it exits with an error message asking to install cmake.
Changelog:
[Internal] - Check whether Cmake is present for RNTester
Differential Revision: D48821932